feat(nodejs): add base images for Node.js weblogs#7013
Merged
Conversation
Contributor
|
|
2 tasks
|
Introduces pre-built base images for Node.js weblogs (express4, express5, fastify, express4-typescript, nextjs) published to Docker Hub via a bake file. Adds build_nodejs_base_images.sh script and CI integration with a build-nodejs-base-images label trigger. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
rochdev
force-pushed
the
rochdev/feat-nodejs-base-images
branch
from
25fba47 to
fc96ec9
Compare
The special case tried to save the base image before it was pulled locally, causing docker save to fail silently through the pipe and produce an empty tarball. The end-to-end job then failed to load it. The standard flow (build full weblog, save system_tests/weblog) already handles nodejs correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cbeauchesne
reviewed
Jun 3, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cbeauchesne
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.base.Dockerfilefiles for express4, express5, fastify, express4-typescript, and nextjs weblogsdocker-bake.hclfor building all base images at oncebuild_nodejs_base_images.shscriptci.yml,system-tests.yml) with abuild-nodejs-base-imageslabel triggerget_pr_merged_labels.shto handle the new labelFROM datadog/system-tests:<weblog>.base-v1Dependencies
zstdinbuild.shNotes
build.shfor self-consistency. Those lines will need to be removed once perf(build): use zstd instead of gzip for weblog image compression #7011 merges.Test plan
build-nodejs-base-imageslabel and verify base images build in CIFROM datadog/system-tests:express4.base-v1build and run correctly🤖 Generated with Claude Code